Skip to content

ci: use ubuntu-latest github image #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

SMoraisAnsys
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys commented Mar 27, 2025

Description

It seems that the reason the ubuntu image is pinned down to 22.04 is related to a lib that is no longer available in 24.04 (current latest). Just checking if those changes could fix this and if you want to use a newer version of the ubuntu github image :)

Also I removed lib duplicates in the a devcontainer's Dockerfile.

Note

There is still an issue related to the glibc version. This is already associated to an issue where maintainers from setup-python have answer and I'm adding a link to the section below for traceability :)

Issue linked

Related to #3659
Related to ansys/ansys-tools-path#268
Related to actions/setup-python#1053

Checklist

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@wiz-inc-572fc38784
Copy link
Contributor

wiz-inc-572fc38784 bot commented Mar 27, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations 2 Medium
Total 2 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Mar 27, 2025
@germa89
Copy link
Collaborator

germa89 commented Mar 27, 2025

This might requires more changes on the container, which will come with the new CICD flavour. I will keep an eye on this.

Thank you @SMoraisAnsys :)

@germa89
Copy link
Collaborator

germa89 commented Apr 1, 2025

@SMoraisAnsys so it seems to me I just need to update the GCLIB to at least to 2.39 in order to get rid of this issue.

It is probably more convenient to just update the docker image to run Ubuntu 24.04 I guess, instead of recompiling GLIB in 20.04.

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (e0dd5d6) to head (ccafcb3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3814   +/-   ##
=======================================
  Coverage   88.36%   88.36%           
=======================================
  Files         187      187           
  Lines       14761    14761           
=======================================
  Hits        13044    13044           
  Misses       1717     1717           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
Copy link
Collaborator

germa89 commented Apr 2, 2025

@SMoraisAnsys can I get some clarification on why ibglx-mesa0 instead of libgl1-mesa-glx ?? Because very likely I am going to port that change to the container builder repo.

@germa89
Copy link
Collaborator

germa89 commented Apr 7, 2025

@SMoraisAnsys ... why now everything is passing? wtf....

@germa89
Copy link
Collaborator

germa89 commented Apr 11, 2025

@SMoraisAnsys If the CICD pass, I see no reason to not merge.

@pyansys-ci-bot LGTM

@germa89 germa89 marked this pull request as ready for review April 11, 2025 17:56
@germa89 germa89 requested a review from a team as a code owner April 11, 2025 17:56
@germa89 germa89 requested review from germa89 and clatapie April 11, 2025 17:56
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@SMoraisAnsys
Copy link
Contributor Author

Sry @germa89 didnt have a look here in quite a while. I'll do that when I've got time. If I remember correctly, the issue was coming from setup-python action

@SMoraisAnsys
Copy link
Contributor Author

SMoraisAnsys commented Apr 12, 2025

@SMoraisAnsys can I get some clarification on why ibglx-mesa0 instead of libgl1-mesa-glx ?? Because very likely I am going to port that change to the container builder repo.

The reason for that change is that this package is no longer available in ubuntu 24.04.
It seems that the mesa developers have split out the FLX backend into a separate library. See https://askubuntu.com/a/1520333

Ask Ubuntu
I'm trying to install libgl1-mesa-glx since I need it to run packettracer. fabio@fabio-MS-7750:~/packettracer$ sudo apt-get install libgl1-mesa-glx Reading package lists... Done Building dependency...

@SMoraisAnsys
Copy link
Contributor Author

@SMoraisAnsys so it seems to me I just need to update the GCLIB to at least to 2.39 in order to get rid of this issue.

It is probably more convenient to just update the docker image to run Ubuntu 24.04 I guess, instead of recompiling GLIB in 20.04.

Seems like the glibc of the container image used is now updated and doesn't conflict any more. Since the two points that we blocking the migration to Ubuntu 24.04 were the glibc version and the requirement for new system package, I think this PR can be merged :)

@germa89 germa89 enabled auto-merge (squash) April 14, 2025 09:47
@germa89
Copy link
Collaborator

germa89 commented Apr 14, 2025

@SMoraisAnsys failing again...

I guess a previous merge from main deleted your changes? Until I restored them in 257a8e7

Only the local tests fail.... I guess I am going to be forced to update to Ubuntu 24:04 ...

Ref: https://www.reddit.com/r/linux4noobs/comments/1bycyya/running_into_a_version_glibc_238_not_found_error/

@germa89
Copy link
Collaborator

germa89 commented Apr 15, 2025

Since this requires changes on the container, and I opened already an issue for that, I'm closing this PR. I will reopen it in the future.

https://github.com/ansys-internal/mapdl-docker-image-builder/issues/155

@germa89 germa89 closed this Apr 15, 2025
auto-merge was automatically disabled April 15, 2025 16:26

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants