-
Notifications
You must be signed in to change notification settings - Fork 131
ci: use ubuntu-latest github image #3814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
This might requires more changes on the container, which will come with the new Thank you @SMoraisAnsys :) |
@SMoraisAnsys so it seems to me I just need to update the It is probably more convenient to just update the docker image to run Ubuntu 24.04 I guess, instead of recompiling GLIB in 20.04. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3814 +/- ##
=======================================
Coverage 88.36% 88.36%
=======================================
Files 187 187
Lines 14761 14761
=======================================
Hits 13044 13044
Misses 1717 1717 🚀 New features to boost your workflow:
|
@SMoraisAnsys can I get some clarification on why |
@SMoraisAnsys ... why now everything is passing? wtf.... |
@SMoraisAnsys If the CICD pass, I see no reason to not merge. @pyansys-ci-bot LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry @germa89 didnt have a look here in quite a while. I'll do that when I've got time. If I remember correctly, the issue was coming from setup-python action |
The reason for that change is that this package is no longer available in ubuntu 24.04.
|
Seems like the |
@SMoraisAnsys failing again... I guess a previous merge from main deleted your changes? Until I restored them in 257a8e7 Only the local tests fail.... I guess I am going to be forced to update to Ubuntu 24:04 ... |
Since this requires changes on the container, and I opened already an issue for that, I'm closing this PR. I will reopen it in the future. https://github.com/ansys-internal/mapdl-docker-image-builder/issues/155 |
Pull request was closed
Description
It seems that the reason the ubuntu image is pinned down to
22.04
is related to a lib that is no longer available in24.04
(current latest). Just checking if those changes could fix this and if you want to use a newer version of the ubuntu github image :)Also I removed lib duplicates in the a devcontainer's Dockerfile.
Note
There is still an issue related to the
glibc
version. This is already associated to an issue where maintainers fromsetup-python
have answer and I'm adding a link to the section below for traceability :)Issue linked
Related to #3659
Related to ansys/ansys-tools-path#268
Related to actions/setup-python#1053
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)